Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block dag deploy update for Cicd Enforced deployments #1327

Merged
merged 10 commits into from
Aug 1, 2023

Conversation

kushalmalani
Copy link
Contributor

@kushalmalani kushalmalani commented Jul 31, 2023

Description

Describe the purpose of this pull request.

Throw warning on dag deploy update and image and dag deploy for CICD Enforced deployments when performed by a user personal access token

🎟 Issue(s)

Related #1276, #1282

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

Throw a warning Enabling/Disabling Dag Deploy and Astro Deploy when acted upon a ci-cd enforced deployment by a user

Screenshot 2023-07-31 at 16 07 33
Screenshot 2023-07-31 at 16 08 01

Do not block normal update operations

Screenshot 2023-07-31 at 11 31 28

Should be able deploy if you are using an api key or token on ci-cd enforced deployment

Screenshot 2023-07-31 at 11 31 51

Can enable/disable dag only deploy if done via api key or token

Screenshot 2023-07-31 at 11 32 07

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@kushalmalani kushalmalani self-assigned this Jul 31, 2023
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Patch coverage: 94.28% and project coverage change: +0.01% 🎉

Comparison is base (c2bcc04) 87.17% compared to head (a71a943) 87.19%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1327      +/-   ##
==========================================
+ Coverage   87.17%   87.19%   +0.01%     
==========================================
  Files         114      114              
  Lines       13367    13399      +32     
==========================================
+ Hits        11653    11683      +30     
- Misses       1025     1026       +1     
- Partials      689      690       +1     
Files Changed Coverage Δ
cloud/deployment/deployment.go 91.36% <90.00%> (-0.05%) ⬇️
cloud/deploy/deploy.go 71.46% <100.00%> (+0.28%) ⬆️
cloud/deployment/fromfile/fromfile.go 97.79% <100.00%> (+0.04%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kushalmalani kushalmalani marked this pull request as ready for review July 31, 2023 18:01
Copy link
Contributor

@neel-astro neel-astro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for all the detailed screenshots and tests

@kushalmalani kushalmalani merged commit 4813005 into main Aug 1, 2023
@kushalmalani kushalmalani deleted the block-update-cicd-enforced-deployment branch August 1, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants