-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block dag deploy update for Cicd Enforced deployments #1327
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1327 +/- ##
==========================================
+ Coverage 87.17% 87.19% +0.01%
==========================================
Files 114 114
Lines 13367 13399 +32
==========================================
+ Hits 11653 11683 +30
- Misses 1025 1026 +1
- Partials 689 690 +1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for all the detailed screenshots and tests
Description
Throw warning on dag deploy update and image and dag deploy for CICD Enforced deployments when performed by a user personal access token
🎟 Issue(s)
Related #1276, #1282
🧪 Functional Testing
📸 Screenshots
Throw a warning Enabling/Disabling Dag Deploy and Astro Deploy when acted upon a ci-cd enforced deployment by a user
Do not block normal update operations
Should be able deploy if you are using an api key or token on ci-cd enforced deployment
Can enable/disable dag only deploy if done via api key or token
📋 Checklist
make test
before taking out of draftmake lint
before taking out of draft