Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consume workload identity from core api #1333

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Conversation

melugoyal
Copy link
Contributor

Description

removes the hardcoded CLI logic for this and consumes the correct value from core API.

🎟 Issue(s)

Related #XXX

🧪 Functional Testing

tested locally using ./astro deployment inspect

📸 Screenshots

image

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@melugoyal melugoyal force-pushed the fix-workload-identity branch from 31a4298 to f50a9e7 Compare August 1, 2023 18:37
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02% 🎉

Comparison is base (eacb540) 87.19% compared to head (f50a9e7) 87.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1333      +/-   ##
==========================================
+ Coverage   87.19%   87.22%   +0.02%     
==========================================
  Files         114      114              
  Lines       13402    13390      -12     
==========================================
- Hits        11686    11679       -7     
+ Misses       1026     1023       -3     
+ Partials      690      688       -2     
Files Changed Coverage Δ
cloud/deployment/inspect/inspect.go 88.50% <100.00%> (+1.70%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sunkickr sunkickr merged commit abba64e into main Aug 2, 2023
@sunkickr sunkickr deleted the fix-workload-identity branch August 2, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants