Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix run dag #1339

Merged
merged 3 commits into from
Aug 3, 2023
Merged

fix run dag #1339

merged 3 commits into from
Aug 3, 2023

Conversation

sunkickr
Copy link
Contributor

@sunkickr sunkickr commented Aug 3, 2023

Description

fix run dag error in 1.18

🎟 Issue(s)

Related #XXX

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@kaxil
Copy link
Contributor

kaxil commented Aug 3, 2023

We should add a test-case which would have caught this regression

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (fb0db40) 86.92% compared to head (e3e7b46) 86.91%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1339      +/-   ##
==========================================
- Coverage   86.92%   86.91%   -0.01%     
==========================================
  Files         114      114              
  Lines       13872    13873       +1     
==========================================
  Hits        12058    12058              
- Misses       1083     1084       +1     
  Partials      731      731              
Files Changed Coverage Δ
airflow/docker_image.go 84.92% <100.00%> (+0.04%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sunkickr sunkickr merged commit ccb6ef2 into main Aug 3, 2023
@sunkickr sunkickr deleted the fix-run-dag branch August 3, 2023 21:32
kushalmalani pushed a commit that referenced this pull request Aug 3, 2023
* fix run dag

* add test

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants