Default dag deploy for hosted #1345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neel-astro
approved these changes
Aug 8, 2023
| @@ -33,6 +33,7 @@ var ( | |||
| errInvalidValue = errors.New("is not valid") | |||
| errNotPermitted = errors.New("is not permitted") | |||
| canCiCdDeploy = deployment.CanCiCdDeploy | |||
| dagDeploy bool | |||
There was a problem hiding this comment.
nit: this should be part of CreateOrUpdate function logic, since this variable is local to that function only
There was a problem hiding this comment.
it's used in CreateOrUpdate and getCreateOrUpdateInput
There was a problem hiding this comment.
ahh, it's better to pass the variable as a function argument to getCreateOrUpdateInput instead of using a global variable. That way function is more readable
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1345 +/- ##
==========================================
- Coverage 86.92% 86.90% -0.02%
==========================================
Files 114 114
Lines 13872 13889 +17
==========================================
+ Hits 12058 12070 +12
- Misses 1083 1085 +2
- Partials 731 734 +3
☔ View full report in Codecov by Sentry. |
kushalmalani
approved these changes
Aug 8, 2023
kushalmalani
pushed a commit
that referenced
this pull request
Aug 9, 2023
* dag deploy enabled by default in hosted * dag deploy enabled by default in hosted from file * fix from file * fix lint * fix test * fix test * fix test * fix test * update test coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
dag deploy enabled by default for hosted
🎟 Issue(s)
🧪 Functional Testing
manual testing in dev in a both a hybrid and hosted org
📸 Screenshots
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft