Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing workload identity on inspect #1359

Merged
merged 5 commits into from
Aug 21, 2023
Merged

Conversation

kushalmalani
Copy link
Contributor

@kushalmalani kushalmalani commented Aug 17, 2023

Description

Describe the purpose of this pull request.

Fixing workload identity on inspect

🎟 Issue(s)

Related #1362

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (046705c) 86.87% compared to head (a6f42c8) 86.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1359      +/-   ##
==========================================
+ Coverage   86.87%   86.89%   +0.01%     
==========================================
  Files         114      114              
  Lines       13879    13882       +3     
==========================================
+ Hits        12058    12063       +5     
+ Misses       1086     1085       -1     
+ Partials      735      734       -1     
Files Changed Coverage Δ
cloud/deployment/inspect/inspect.go 88.66% <100.00%> (+0.16%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@neel-astro neel-astro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of minor nits, otherwise LGTM. Thanks for the quick fix

cloud/deployment/fromfile/fromfile_test.go Outdated Show resolved Hide resolved
cloud/deployment/inspect/inspect.go Outdated Show resolved Hide resolved
@kushalmalani kushalmalani requested a review from melugoyal August 17, 2023 07:35
Copy link
Contributor

@melugoyal melugoyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving with the assumption that #1359 (comment) will be resolved in the future

@kushalmalani kushalmalani self-assigned this Aug 21, 2023
@kushalmalani kushalmalani merged commit bf28325 into main Aug 21, 2023
@kushalmalani kushalmalani deleted the fix-workload-identity-inspect branch August 21, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants