Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy DAGs folder before running pytest command #1368

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Copy DAGs folder before running pytest command #1368

merged 1 commit into from
Aug 29, 2023

Conversation

neel-astro
Copy link
Contributor

Description

Changes:

  • Fix potentially missing DAGs folder when pytest is run during astro deploy with dags only deploy. This change would explicitly copy the DAGs folder before running the pytest container.

🎟 Issue(s)

Original change: #1351
Slack thread conversation: https://astronomer.slack.com/archives/CL44PA4DB/p1692987720142969

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

All tests passing, on a Linux CI machine
Screenshot 2023-08-28 at 5 17 45 PM

Copied advanced DAG file to dags/test-dags, so that pytest would fail because of duplicate DAGs, and it would also show that the DAGs folder is being picked up for pytest when running dags deploy
Screenshot 2023-08-28 at 5 24 02 PM

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@f142e1d). Click here to learn what that means.
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1368   +/-   ##
=======================================
  Coverage        ?   86.85%           
=======================================
  Files           ?      114           
  Lines           ?    13922           
  Branches        ?        0           
=======================================
  Hits            ?    12092           
  Misses          ?     1092           
  Partials        ?      738           
Files Changed Coverage Δ
airflow/docker_image.go 82.89% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neel-astro neel-astro merged commit c05a3b2 into main Aug 29, 2023
@neel-astro neel-astro deleted the fix/pytest branch August 29, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants