Fix .astro folder not present in few images causing failure for parse command #1375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kushalmalani
approved these changes
Aug 30, 2023
neel-astro
added a commit
that referenced
this pull request
Aug 30, 2023
… command (#1375) * Fix .astro folder not present in few images causing failure for parse command * Fix typo in comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes:
.astrofolder for pytest. The.astrois getting docker ignored on a few machines, but not on all machines. So in order to have consistent behavior, since parse logic requires files from.astro, this PR adds changes to explicitly copy.astrofolder to the container running pytest & parse command.🎟 Issue(s)
Related #1374
🧪 Functional Testing
📸 Screenshots
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft