Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create fix #1380

Merged
merged 3 commits into from
Sep 6, 2023
Merged

Create fix #1380

merged 3 commits into from
Sep 6, 2023

Conversation

sunkickr
Copy link
Contributor

@sunkickr sunkickr commented Sep 6, 2023

Description

fix an issue where you can't create a hosted deployment in CI/CD sometimes

🎟 Issue(s)

Related #XXX

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (dd5ba95) 86.85% compared to head (2312013) 86.85%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1380   +/-   ##
=======================================
  Coverage   86.85%   86.85%           
=======================================
  Files         114      114           
  Lines       13904    13904           
=======================================
  Hits        12076    12076           
  Misses       1091     1091           
  Partials      737      737           
Files Changed Coverage Δ
cmd/cloud/deployment.go 93.59% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sunkickr sunkickr merged commit a952045 into main Sep 6, 2023
@sunkickr sunkickr deleted the create-fix branch September 6, 2023 16:45
kushalmalani pushed a commit that referenced this pull request Sep 12, 2023
* test again

* fix issue

* fix spacing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants