add workspace id as flag to workspace team add cmd #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliotta
requested review from
neel-astro,
kushalmalani and
sunkickr
as code owners
neel-astro
approved these changes
Sep 8, 2023
| @@ -407,6 +407,7 @@ func newWorkspaceTeamAddCmd(out io.Writer) *cobra.Command { | |||
| return addWorkspaceTeam(cmd, args, out) | |||
| }, | |||
| } | |||
| cmd.Flags().StringVarP(&workspaceID, "workspace-id", "w", "", "The Workspace's unique identifier") | |||
There was a problem hiding this comment.
Suggested change
| cmd.Flags().StringVarP(&workspaceID, "workspace-id", "w", "", "The Workspace's unique identifier") | |
| cmd.Flags().StringVarP(&workspaceID, "workspace-id", "w", "", "workspace where you would like to add the team") |
keeping it consistent with other workspace-id flag description in this file
kushalmalani
pushed a commit
that referenced
this pull request
Sep 12, 2023
* add workspace id as flag to workspace team add cmd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds workspace id as optional param to workspace team add cmd.
Motivation: the docs team was asked to provide a script that would allow an org to add a team to multiple workspaces. This is difficult without this command.
🧪 Functional Testing
Tested locally against dev with and without flag passed in. All worked as expected.
📸 Screenshots
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft