Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin latest cli version in godownloader #1395

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Conversation

kushalmalani
Copy link
Contributor

@kushalmalani kushalmalani commented Sep 21, 2023

Description

Describe the purpose of this pull request.

Pin latest cli version in godownloader. We dont need to hit github APIs to fetch/check latest versions

🎟 Issue(s)

Related #XXX

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

Screenshot 2023-09-21 at 10 54 25

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2729cc8) 86.94% compared to head (8107ddf) 86.94%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1395   +/-   ##
=======================================
  Coverage   86.94%   86.94%           
=======================================
  Files         114      114           
  Lines       13948    13948           
=======================================
  Hits        12127    12127           
  Misses       1084     1084           
  Partials      737      737           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kushalmalani kushalmalani merged commit 4a0cc1f into main Sep 25, 2023
@kushalmalani kushalmalani deleted the pin-latest-go-downloader branch September 25, 2023 17:51
neel-astro pushed a commit that referenced this pull request Oct 11, 2023
* Pin latest cli version in godownloader

* Updating log print
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants