Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated error context #1397

Merged
merged 2 commits into from
Oct 11, 2023
Merged

updated error context #1397

merged 2 commits into from
Oct 11, 2023

Conversation

erdos2n
Copy link
Contributor

@erdos2n erdos2n commented Sep 22, 2023

Description

🎟 Issue(s)

Related #1396

🧪 Functional Testing

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@erdos2n erdos2n linked an issue Sep 22, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (f2f170d) 86.94% compared to head (9cab3ed) 86.94%.

❗ Current head 9cab3ed differs from pull request most recent head da825b4. Consider uploading reports for the commit da825b4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1397      +/-   ##
==========================================
- Coverage   86.94%   86.94%   -0.01%     
==========================================
  Files         114      114              
  Lines       13951    13948       -3     
==========================================
- Hits        12130    12127       -3     
  Misses       1084     1084              
  Partials      737      737              

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sunkickr sunkickr merged commit 9c97335 into main Oct 11, 2023
@sunkickr sunkickr deleted the 1396-pytest-clarify-expalantion branch October 11, 2023 15:36
neel-astro pushed a commit that referenced this pull request Oct 11, 2023
Co-authored-by: David Koenitzer <davidkoenit@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unclear expalantion
2 participants