Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't print variable value #1401

Merged
merged 1 commit into from
Sep 27, 2023
Merged

don't print variable value #1401

merged 1 commit into from
Sep 27, 2023

Conversation

sunkickr
Copy link
Contributor

Description

Variable value should not be printed in messages in case it is secret

🎟 Issue(s)

🧪 Functional Testing

manual testing

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Patch coverage: 50.00% and no project coverage change.

Comparison is base (2729cc8) 86.94% compared to head (d1272f0) 86.94%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1401   +/-   ##
=======================================
  Coverage   86.94%   86.94%           
=======================================
  Files         114      114           
  Lines       13948    13948           
=======================================
  Hits        12127    12127           
  Misses       1084     1084           
  Partials      737      737           
Files Changed Coverage Δ
cloud/deployment/deployment_variable.go 88.46% <50.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sunkickr sunkickr merged commit 8558554 into main Sep 27, 2023
@sunkickr sunkickr deleted the var-fix branch September 27, 2023 15:16
neel-astro pushed a commit that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants