Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make it so you can create a kuberenetes deployment with a file created from --template #1413

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

sunkickr
Copy link
Contributor

Description

make it so users can use inspect --template to create a kuberenetes deployment

🎟 Issue(s)

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (f2f170d) 86.94% compared to head (20ccdb6) 86.94%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1413   +/-   ##
=======================================
  Coverage   86.94%   86.94%           
=======================================
  Files         114      114           
  Lines       13951    13953    +2     
=======================================
+ Hits        12130    12132    +2     
  Misses       1084     1084           
  Partials      737      737           
Files Coverage Δ
cloud/deployment/inspect/inspect.go 88.78% <100.00%> (+0.11%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sunkickr sunkickr merged commit 2841f46 into main Oct 11, 2023
@sunkickr sunkickr deleted the fix-template branch October 11, 2023 19:24
neel-astro pushed a commit that referenced this pull request Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants