-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow users to add dag_integrity_exceptions.txt to ignore errors #1613
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1613 +/- ##
=======================================
Coverage 86.55% 86.55%
=======================================
Files 114 114
Lines 15935 15936 +1
=======================================
+ Hits 13792 13793 +1
Misses 1288 1288
Partials 855 855 ☔ View full report in Codecov by Sentry. |
@sunkickr I don't know how to make this pass the codecov test |
@collinmcnulty we should also make |
@@ -115,6 +115,7 @@ func Init(path, airflowImageName, airflowImageTag string) error { | |||
"README.md": Readme, | |||
"tests/dags/test_dag_example.py": DagExampleTest, | |||
".astro/test_dag_integrity_default.py": DagIntegrityTestDefault, | |||
".astro/dag_integrity_exceptions.txt": "# Add dag files to exempt from parse test below. ex: dags/<test-file>", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How would users with existing projects fix this? Do we need something in our release notes for this ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah If they want this file they would need to delete .astro/test_dag_integrity_default.py
and run astro dev init
Description
Sometime a DAG doesn't parse in a CI pipeline for a reason that is ok. This provides a way to make that exception just for one dag file instead of having to use
-f
. What I'm not sure of right now is how to put this code such that astro dev parse is what's affected, as we were using an existing astro project.🧪 Functional Testing
I wrote a dag that doesn't parse, made sure it failed astro dev parse. Then added it to tests/dag_integrity_exceptions.txt and it didn't fail to astro dev parse anymore.
📋 Checklist
make test
before taking out of draftmake lint
before taking out of draft