fix example flag names #1630
Merged
fix example flag names #1630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliotta
requested review from
neel-astro,
kushalmalani,
sunkickr and
vandyliu
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1630 +/- ##
=======================================
Coverage 86.75% 86.75%
=======================================
Files 114 114
Lines 16661 16661
=======================================
Hits 14454 14454
Misses 1318 1318
Partials 889 889 ☔ View full report in Codecov by Sentry. |
vandyliu
reviewed
Apr 23, 2024
| @@ -1069,7 +1069,7 @@ func newAddOrganizationTokenDeploymentRole(out io.Writer) *cobra.Command { | |||
| cmd := &cobra.Command{ | |||
| Use: "add [ORG_TOKEN_ID]", | |||
| Short: "Add an Organization API token to a Deployment", | |||
| Long: "Add an Organization API token to a Deployment\n$astro deployment token organization-token add [ORG_TOKEN_ID] --name [token name] --role [DEPLOYMENT_ADMIN or a custom role name].", | |||
| Long: "Add an Organization API token to a Deployment\n$astro deployment token organization-token add [ORG_TOKEN_ID] --org-token-name [token name] --role [DEPLOYMENT_ADMIN or a custom role name].", | |||
There was a problem hiding this comment.
any unit tests we can add for these?
cmd/cloud/workspace.go
Outdated
| @@ -457,7 +457,7 @@ func newRemoveOrganizationTokenWorkspaceRole(out io.Writer) *cobra.Command { | |||
| cmd := &cobra.Command{ | |||
| Use: "remove [ORG_TOKEN_ID]", | |||
| Short: "Remove an Workspace API token's Deployment Role", | |||
| Long: "Remove an Workspace API token's Deployment Role\n$astro workspace token organization-token remove [ORG_TOKEN_ID] --name [token name].", | |||
| Long: "Remove an Workspace API token's Deployment Role\n$astro workspace token organization-token remove [ORG_TOKEN_ID] --org-token-name [token name].", | |||
There was a problem hiding this comment.
Is this correct? The function name is different from what we are calling.
There was a problem hiding this comment.
it was not good eyes. Should be good now.
cmd/cloud/workspace.go
Outdated
| Short: "Remove an Workspace API token's Deployment Role", | ||
| Long: "Remove an Workspace API token's Deployment Role\n$astro workspace token organization-token remove [ORG_TOKEN_ID] --name [token name].", | ||
| Short: "Remove an Organization API token's Workspace Role", | ||
| Long: "Remove an Organization API token's Workspace Role\n$astro workspace token organization-token remove [ORG_TOKEN_ID] --org-token-name [token name].", | ||
| RunE: func(cmd *cobra.Command, args []string) error { | ||
| return removeWorkspaceTokenFromDeploymentRole(cmd, args, out) |
There was a problem hiding this comment.
Does this need updating too then?
kushalmalani
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the flag name of used in the example text for the deployment token management
🎟 Issue(s)
Related #XXX
🧪 Functional Testing
📸 Screenshots
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft