Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug to create a deployment with same name in different workspace #1645

Merged
merged 1 commit into from
May 9, 2024

Conversation

kushalmalani
Copy link
Contributor

@kushalmalani kushalmalani commented May 9, 2024

Description

Describe the purpose of this pull request.

🎟 Issue(s)

Related #1644, #1360

Fix a bug to create a deployment with same name in different workspace

astrolocal deployment create --deployment-file ~/Desktop/temp.yaml
deployment:
    configuration:
        name: kushal-test

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.76%. Comparing base (8c81403) to head (07edd0b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1645   +/-   ##
=======================================
  Coverage   86.76%   86.76%           
=======================================
  Files         114      114           
  Lines       16693    16693           
=======================================
  Hits        14483    14483           
  Misses       1323     1323           
  Partials      887      887           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kushalmalani kushalmalani merged commit 5e0cdac into main May 9, 2024
4 of 5 checks passed
@kushalmalani kushalmalani deleted the fix-deployment-file-create branch May 9, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants