Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dbt delete without project path #1678

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Conversation

jeremybeard
Copy link
Contributor

Description

This change fixes a bug in astro dbt delete where if the project path is not specified then it does not correctly look at the current working directory for the dbt project.

🧪 Functional Testing

  • Unit tests
  • Manually tested

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.33%. Comparing base (a8e81d7) to head (d3322ab).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1678      +/-   ##
==========================================
+ Coverage   86.31%   86.33%   +0.01%     
==========================================
  Files         116      116              
  Lines       17052    17055       +3     
==========================================
+ Hits        14719    14724       +5     
+ Misses       1403     1402       -1     
+ Partials      930      929       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeremybeard jeremybeard merged commit 1269e8f into main Jul 17, 2024
4 of 5 checks passed
@jeremybeard jeremybeard deleted the fix-dbt-delete-project-path branch July 17, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants