track github action deploys #1679
Conversation
sunkickr
requested review from
neel-astro,
kushalmalani and
vandyliu
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1679 +/- ##
=======================================
Coverage 86.27% 86.27%
=======================================
Files 117 117
Lines 17085 17085
=======================================
Hits 14740 14740
Misses 1409 1409
Partials 936 936 ☔ View full report in Codecov by Sentry. |
| @@ -58,9 +59,13 @@ func CoreRequestEditor(ctx httpContext.Context, req *http.Request) error { | |||
| } | |||
| req.URL = requestURL | |||
| req.Header.Add("authorization", currentCtx.Token) | |||
| req.Header.Add("x-astro-client-identifier", "cli") | |||
| if os.Getenv("GITHUB_ACTIONS") == "true" { | |||
| req.Header.Add("x-astro-client-identifier", "github-action") | |||
There was a problem hiding this comment.
Can we track github actions version also?
There was a problem hiding this comment.
we should make the user agent also for github actions
There was a problem hiding this comment.
i'm not really sure how to do that
| req.Header.Add("x-astro-client-version", os.Getenv("DEPLOY_ACTION_VERSION")) | ||
| case os.Getenv("GITHUB_ACTIONS") == "true": | ||
| req.Header.Add("x-astro-client-identifier", "deploy-action") | ||
| req.Header.Add("x-astro-client-version", version.CurrVersion) |
There was a problem hiding this comment.
would this be the cli or deploy actions version?
There was a problem hiding this comment.
my bad that should say github-action. github action doesn't have a version so CLI version gives us more info about what version of the CLI they are using within their github-action
Description
This change will make the header for client
github-actionfor all requests the CLI makes within a github action workflow. This will help us see how many customers are using github actions to deploy🎟 Issue(s)
Related #XXX
🧪 Functional Testing
📸 Screenshots
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft