Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduction of sha_as_tag=True config in astro cli which will be used during Astro deploy #1752

Merged
merged 8 commits into from
Dec 11, 2024
Merged

Introduction of sha_as_tag=True config in astro cli which will be used during Astro deploy #1752

merged 8 commits into from
Dec 11, 2024

Conversation

rujhan-arora-astronomer
Copy link
Contributor

@rujhan-arora-astronomer rujhan-arora-astronomer commented Dec 10, 2024 •
edited
Loading

Description

Introduction of sha_as_tag=True config in astro cli which will be used during Astro deploy.

  1. Option to set sha_as_tag true in config.
  2. During astro deploy, using the sha digest when we make a call to the updateDeploymentImage endpoint in Houston, instead of the runtime version tag.

🎟 Issue(s)

Related https://github.com/astronomer/issues/issues/6836

🧪 Functional Testing

Testing locally and on staging cluster too.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

neel-astro
neel-astro reviewed Dec 10, 2024
View reviewed changes
Copy link
Contributor

@neel-astro neel-astro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment to squash, but looks ok otherwise

airflow/docker_image.go Outdated Show resolved Hide resolved
neel-astro
neel-astro reviewed Dec 11, 2024
View reviewed changes
Copy link
Contributor

@neel-astro neel-astro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left final set of comments, but LGTM otherwise

airflow/container.go Outdated Show resolved Hide resolved
software/deploy/deploy.go Outdated Show resolved Hide resolved
software/deploy/deploy.go Show resolved Hide resolved
software/deploy/deploy.go Show resolved Hide resolved
@neel-astro neel-astro merged commit c13b5f8 into main Dec 11, 2024
3 checks passed
@neel-astro neel-astro deleted the feature/6836 branch December 11, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neel-astro neel-astro neel-astro approved these changes

@jeremybeard jeremybeard Awaiting requested review from jeremybeard jeremybeard is a code owner

@kushalmalani kushalmalani Awaiting requested review from kushalmalani kushalmalani is a code owner

@pgvishnuram pgvishnuram Awaiting requested review from pgvishnuram

@rob-1126 rob-1126 Awaiting requested review from rob-1126

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rujhan-arora-astronomer @neel-astro