Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added --image flag for astro deploy command for software #1753

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Conversation

rujhan-arora-astronomer
Copy link
Contributor

@rujhan-arora-astronomer rujhan-arora-astronomer commented Dec 11, 2024

Description

Added --image flag for astro deploy command for software
This command would throw an error for image-based deployments.
It would deploy the image for other types of deployments.
For dag-only deployments, it would not upload the dags present in the dags folder in the local directory.

🎟 Issue(s)

Related #XXX

🧪 Functional Testing and Screenshots

Locally
Screenshot 2024-12-12 at 11 47 27 AM
Screenshot 2024-12-12 at 11 48 45 AM
Screenshot 2024-12-12 at 11 49 17 AM
Screenshot 2024-12-12 at 11 49 30 AM

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

Copy link
Contributor

@neel-astro neel-astro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, apart from a minor nit

cmd/software/deploy.go Show resolved Hide resolved
@neel-astro neel-astro merged commit dce037b into main Dec 12, 2024
3 checks passed
@neel-astro neel-astro deleted the 6847 branch December 12, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants