Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update context switch command #769

Merged
merged 5 commits into from
Sep 29, 2022
Merged

update context switch command #769

merged 5 commits into from
Sep 29, 2022

Conversation

sunkickr
Copy link
Contributor

Description

This PR will make it so users can switch into a context without being logged into it. This will make it so users can use API keys with contexts that are not prod

🎟 Issue(s)

🧪 Functional Testing

📸 Screenshots

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Base: 87.01% // Head: 86.99% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (2a036df) compared to base (e8be877).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #769      +/-   ##
==========================================
- Coverage   87.01%   86.99%   -0.03%     
==========================================
  Files          97       97              
  Lines        8266     8266              
==========================================
- Hits         7193     7191       -2     
- Misses        631      633       +2     
  Partials      442      442              
Impacted Files Coverage Δ
cloud/auth/auth.go 79.33% <ø> (+0.38%) ⬆️
context/context.go 84.81% <0.00%> (-4.53%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sunkickr sunkickr marked this pull request as ready for review September 28, 2022 21:06
@kushalmalani
Copy link
Contributor

Would this work with github actions if they dont have any context to switch?

@sunkickr
Copy link
Contributor Author

Would this work with github actions if they dont have any context to switch?

Yes if they don't have a context it will create it. I tested by deleting a context from my .astro config and then switching to it

@sunkickr sunkickr merged commit 82d8d51 into main Sep 29, 2022
@sunkickr sunkickr deleted the fix-context-switch branch September 29, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants