Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deployment.go - CLI displayed documentation #789

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

frankcash
Copy link
Contributor

Description

Updates CLI displayed documentation for astro deployment create

🎟 Issue(s)

N/A

🧪 Functional Testing

N/A

📸 Screenshots

N/A

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Base: 86.84% // Head: 86.84% // No change to project coverage 👍

Coverage data is based on head (a1717b2) compared to base (45a3eb8).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #789   +/-   ##
=======================================
  Coverage   86.84%   86.84%           
=======================================
  Files          97       97           
  Lines        8315     8315           
=======================================
  Hits         7221     7221           
  Misses        644      644           
  Partials      450      450           
Impacted Files Coverage Δ
cmd/software/deployment.go 94.32% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@neel-astro neel-astro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping it up to date ❤️

@frankcash
Copy link
Contributor Author

@neel-astro of course, I think the fact that I copy and pasted an example and it didn't work was the main impetus 😆

@neel-astro neel-astro merged commit e7bcd33 into main Oct 6, 2022
@neel-astro neel-astro deleted the frankcash-patch-1 branch October 6, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants