fix colima deploy #800
fix colima deploy #800
Conversation
Codecov ReportBase: 86.98% // Head: 86.92% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #800 +/- ##
==========================================
- Coverage 86.98% 86.92% -0.07%
==========================================
Files 97 97
Lines 8301 8304 +3
==========================================
- Hits 7221 7218 -3
- Misses 636 640 +4
- Partials 444 446 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
sunkickr
requested review from
andriisoldatenko,
aliotta,
neel-astro,
AmFlint and
kushalmalani
as code owners
| conn_port: 5432 | ||
| conn_uri: postgres://username:password@example.db.example.com:5432/schema | ||
| conn_extra: {} | ||
| - conn_id: local_postgres |
There was a problem hiding this comment.
nitpick: could we please fix the tests that cause the update to these test files every time we run the tests? Are your changes in this PR to settings/settings_test.go fixing them?
There was a problem hiding this comment.
yes if the yaml file is like this than the tests shouldn't update the file any more
Description
This PR should fix colima deploy
🎟 Issue(s)
astro deploywith colima is not working #615🧪 Functional Testing
📸 Screenshots
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft