Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ASTRO_CLI env var to flow dockerfile #855

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

feluelle
Copy link
Member

@feluelle feluelle commented Nov 3, 2022

Description

Describe the purpose of this pull request.

🎟 Issue(s)

Related astronomer/astro-sdk#1192

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Base: 87.11% // Head: 87.11% // No change to project coverage 👍

Coverage data is based on head (fe211bc) compared to base (033c89a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #855   +/-   ##
=======================================
  Coverage   87.11%   87.11%           
=======================================
  Files         100      100           
  Lines        8723     8723           
=======================================
  Hits         7599     7599           
  Misses        655      655           
  Partials      469      469           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@feluelle feluelle marked this pull request as ready for review November 3, 2022 10:13
@neel-astro neel-astro merged commit bcd8148 into main Nov 4, 2022
@neel-astro neel-astro deleted the feature/flow-environment-awareness branch November 4, 2022 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants