Fix timeout copy again #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunkickr
requested review from
andriisoldatenko,
aliotta,
neel-astro,
AmFlint,
kushalmalani and
jemishp
as code owners
Codecov ReportBase: 87.42% // Head: 87.42% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #978 +/- ##
=======================================
Coverage 87.42% 87.42%
=======================================
Files 111 111
Lines 9457 9457
=======================================
Hits 8268 8268
Misses 698 698
Partials 491 491
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| fmt.Println("\nProject is not yet running. The project is still attempting to start up. Run 'astro dev logs --webserver | --scheduler' for details.") | ||
| return fmt.Errorf("%w: the health check timed out after %s. Use the --wait flag to increase the time out", errWebServerUnHealthy, timeout) | ||
| fmt.Printf("\n") | ||
| return fmt.Errorf("there might be a problem with your project starting up. The webserver health check timed out after %s but your project will continue trying to start. Run 'astro dev logs --webserver | --scheduler' for details.\n\nTry again or use the --wait flag to increase the time out", timeout) //nolint:goerr113 |
There was a problem hiding this comment.
Can you capitalize the first letter of the error message?
There was a problem hiding this comment.
that breaks the linter
kushalmalani
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix timeout copy again
🎟 Issue(s)
Related #XXX
🧪 Functional Testing
tested manually
📸 Screenshots
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft