Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds .airflowignore #980

Merged
merged 1 commit into from
Dec 21, 2022
Merged

Adds .airflowignore #980

merged 1 commit into from
Dec 21, 2022

Conversation

frankcash
Copy link
Contributor

@frankcash frankcash commented Dec 20, 2022

Description

Adds .airflowignore inside of the dags directory when running astro dev init

To read more about the .airflowignore functionality https://airflow.apache.org/docs/apache-airflow/stable/concepts/dags.html#airflowignore

🎟 Issue(s)

#975

🧪 Functional Testing

go main dev init

ls -la dags

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Base: 87.73% // Head: 87.73% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (29d001e) compared to base (35521f5).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #980   +/-   ##
=======================================
  Coverage   87.73%   87.73%           
=======================================
  Files         112      112           
  Lines        9696     9697    +1     
=======================================
+ Hits         8507     8508    +1     
  Misses        698      698           
  Partials      491      491           
Impacted Files Coverage Δ
airflow/airflow.go 68.88% <100.00%> (+0.70%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@odaneau-astro odaneau-astro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work

@sunkickr sunkickr merged commit 9bcc0a8 into main Dec 21, 2022
@sunkickr sunkickr deleted the frankcash/975 branch December 21, 2022 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants