Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs about using dtype #1903

Merged
merged 12 commits into from
May 12, 2023
Merged

Add docs about using dtype #1903

merged 12 commits into from
May 12, 2023

Conversation

jwitz
Copy link
Contributor

@jwitz jwitz commented Apr 20, 2023

Closes #1902

Adding a tip for using dtype to resolve the situation when the SDK can't automatically infer your schema when loading into a dataframe.

tatiana
tatiana previously approved these changes Apr 21, 2023
@tatiana tatiana self-requested a review April 21, 2023 14:25
Copy link
Collaborator

@tatiana tatiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jwitz, thanks a lot for making it easier for the end users to specify the dataframe schema!

I left a comment inline.

@tatiana tatiana dismissed their stale review April 21, 2023 14:28

Prematurely approved the PR

@phanikumv
Copy link
Collaborator

@sunank200 @pankajastro @pankajkoti please review this PR

Copy link
Contributor

@pankajkoti pankajkoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, looks like build docs is failing. I believe Ankit and Utkarsh have more expertise on this topic, so would like to rely on their review on this PR, please.

cc: @phanikumv

@tatiana tatiana added this to the 1.7.0 milestone May 5, 2023
Copy link
Collaborator

@tatiana tatiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, @jwitz , sorry for all the pain with RST

@tatiana tatiana merged commit 76aa8c0 into astronomer:main May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add note about using load_options when loading from a file directly to a dataframe
6 participants