-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor assume_schema_exists
and expose it in aql.transform
#1925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
load_table_schema_exists
to assume_schema_exists
and expose it in transform
load_table_schema_exists
to assume_schema_exists
and expose it in transform
assume_schema_exists
and expose it in transform
assume_schema_exists
and expose it in transform
assume_schema_exists
and expose it in transform
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1925 +/- ##
==========================================
+ Coverage 84.81% 92.29% +7.48%
==========================================
Files 104 72 -32
Lines 5959 4246 -1713
Branches 678 512 -166
==========================================
- Hits 5054 3919 -1135
+ Misses 762 235 -527
+ Partials 143 92 -51
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
kaxil
reviewed
May 5, 2023
30e8eb9
to
ca57b34
Compare
kaxil
approved these changes
May 5, 2023
assume_schema_exists
and expose it in transform
assume_schema_exists
and expose it in aql.transform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up for #1922. In that PR we allowed users to skip schema check & creation for
aql.load_file
, but we missed the fact thataql.transform
andaql.transform_file
had the same issue. This PR aims to address this limitation.Changes included in this PR:
load_table_schema_exists
toassume_schema_exists
load_file
) argumentschema_exists
toassume_schema_exists
assume_schema_exists
happens. Before, it happened only inside theload_file_to_table
. Now, it is part ofcreate_schema_if_applicable
. This makes this feature available in theaql.transform
task as wellDatabase.create_schema_if_needed
toDatabase.create_schema_if_applicable
assume_schema_exists
inaql.transform