Update the wasb connection

[utkarsharma2]

In version apache-airflow-providers-microsoft-azure==6.2.3 we are no longer getting the self.hook.get_conn().account_name to bypass the issue we can create connection in below fashion:

- conn_id: wasb_conn_with_access_key
  conn_type: wasb
  login: astrosdk
  host: astrosdk.blob.core.windows.net
  description: null
  extra:
    shared_access_key: $AZURE_WASB_ACCESS_KEY

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (c593075) 89.67% compared to head (44186f9) 89.67%.
Report is 1 commits behind head on main.

❗ Current head 44186f9 differs from pull request most recent head 7630152. Consider uploading reports for the commit 7630152 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1994   +/-   ##
=======================================
  Coverage   89.67%   89.67%           
=======================================
  Files          72       72           
  Lines        4262     4262           
  Branches      530      530           
=======================================
  Hits         3822     3822           
  Misses        343      343           
  Partials       97       97           

Flag	Coverage Δ
PythonSDK	89.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ephraimbuddy]

In version apache-airflow-providers-microsoft-azure==6.2.3 we are no longer getting the self.hook.get_conn().account_name

Why are we no longer getting it? If it's a regression, we need to fix it in airflow
Limiting this will cause issues in runtime

[pankajastro]

do we have some ticket for this in upstream lib, I feel that way it is easy to track.

[utkarsharma2]

just created an upstream bug, will create a bug on our end as well - apache/airflow#33203

[utkarsharma2]

@ephraimbuddy Yes, I think so, it's a bug in the latest release 6.2.3. I'm planning to look into it post-releasing SDK.

[ephraimbuddy]

@ephraimbuddy Yes, I think so, it's a bug in the latest release 6.2.3. I'm planning to look into it post-releasing SDK.

If we release this, it won't work with runtime so why release now instead of fixing the issue and making it part of the current providers release?

[utkarsharma2]

@ephraimbuddy There is a customer waiting for pandas 2.0 support which is part of this release.
Here - https://astronomer.slack.com/archives/C02B8SPT93K/p1689013818453639

[phanikumv]

@ephraimbuddy There is a customer waiting for pandas 2.0 support which is part of this release. Here - https://astronomer.slack.com/archives/C02B8SPT93K/p1689013818453639

But they would access cloud IDE by (indirectly) using Astro runtime right?

[utkarsharma2]

@phanikumv I'm not sure if they use runtime or not. But as @ephraimbuddy suggested a fix in connection, should unlock us from runtime issue as well. I'm trying the fix as we speak.

[tatiana]

@utkarsharma2, we could also try to change how we build the URL in this part of the code:
https://github.com/astronomer/astro-sdk/blob/main/python-sdk/src/astro/files/locations/azure/wasb.py#L123-L142

It seems the get_conn may expose a field account_url, we could try it out:
https://github.com/apache/airflow/blob/main/airflow/providers/microsoft/azure/hooks/wasb.py#L193C25-L193C36

[utkarsharma2]

@tatiana I looked into it and even account_url is not populating the account_name