Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Tatiana Al-Chueyr <tatiana.alchueyr@gmail.com>
  • Loading branch information
pankajkoti and tatiana committed Jul 24, 2024
1 parent e7370d1 commit ecee4db
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: test

on:
push: # Run on pushes to the default branch
branches: [main, 448-remote-manifest-support]
branches: [main]
pull_request_target: # Also run on pull requests originated from forks
branches: [main]

Expand Down
6 changes: 3 additions & 3 deletions docs/configuration/parsing-methods.rst
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ Examples of how to supply ``manifest.json`` using ``manifest_path`` argument:
:start-after: [START local_example]
:end-before: [END local_example]

- AWS S3 URL:
- AWS S3 URL (available since Cosmos 1.6):

Ensure that you have the required dependencies installed to use the S3 URL. You can install the required dependencies
using the following command: ``pip install "astronomer-cosmos[amazon]"``
Expand All @@ -71,7 +71,7 @@ using the following command: ``pip install "astronomer-cosmos[amazon]"``
:start-after: [START aws_s3_example]
:end-before: [END aws_s3_example]

- GCP GCS URL:
- GCP GCS URL (available since Cosmos 1.6):

Ensure that you have the required dependencies installed to use the GCS URL. You can install the required dependencies
using the following command: ``pip install "astronomer-cosmos[google]"``
Expand All @@ -81,7 +81,7 @@ using the following command: ``pip install "astronomer-cosmos[google]"``
:start-after: [START gcp_gs_example]
:end-before: [END gcp_gs_example]

- Azure Blob Storage URL:
- Azure Blob Storage URL (available since Cosmos 1.6):

Ensure that you have the required dependencies installed to use the Azure blob URL. You can install the required
dependencies using the following command: ``pip install "astronomer-cosmos[microsoft]"``
Expand Down

0 comments on commit ecee4db

Please sign in to comment.