Fix docs so it does not reference non-existing get_dbt_dataset
#1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
✅ Deploy Preview for sunny-pastelito-5ecb04 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dosubot
bot
added
the
area:docs
pankajkoti
reviewed
Jun 7, 2024
pankajkoti
approved these changes
Jun 7, 2024
pankajkoti
pushed a commit
that referenced
this pull request
Jun 7, 2024
[The documentation](https://astronomer.github.io/astronomer-cosmos/configuration/scheduling.html) was outdated. The method `get_dbt_dataset` no longer exists. It used to exist in older versions of Cosmos (before 1.1) when the URIs respected the format: `Dataset(f"DBT://{connection_id.upper()}/{project_name.upper()}/{model_name.upper()}")` More information on why we changed this: #305 Closes: #1032 (cherry picked from commit c47e104)
Merged
pankajkoti
added a commit
that referenced
this pull request
Jun 7, 2024
Bug fixes * Bring back ``dataset`` as a required field for BigQuery profile by @pankajkoti in #1033 Enhancements * Only run ``dbt deps`` when there are dependencies by @tatiana in #1030 Docs * Fix docs so it does not reference non-existing ``get_dbt_dataset`` by @tatiana in #1034 --------- Co-authored-by: Tatiana Al-Chueyr <tatiana.alchueyr@gmail.com>
1 task
arojasb3
pushed a commit
to arojasb3/astronomer-cosmos
that referenced
this pull request
Jul 14, 2024
…ronomer#1034) [The documentation](https://astronomer.github.io/astronomer-cosmos/configuration/scheduling.html) was outdated. The method `get_dbt_dataset` no longer exists. It used to exist in older versions of Cosmos (before 1.1) when the URIs respected the format: `Dataset(f"DBT://{connection_id.upper()}/{project_name.upper()}/{model_name.upper()}")` More information on why we changed this: astronomer#305 Closes: astronomer#1032
arojasb3
pushed a commit
to arojasb3/astronomer-cosmos
that referenced
this pull request
Jul 14, 2024
Bug fixes * Bring back ``dataset`` as a required field for BigQuery profile by @pankajkoti in astronomer#1033 Enhancements * Only run ``dbt deps`` when there are dependencies by @tatiana in astronomer#1030 Docs * Fix docs so it does not reference non-existing ``get_dbt_dataset`` by @tatiana in astronomer#1034 --------- Co-authored-by: Tatiana Al-Chueyr <tatiana.alchueyr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation was outdated.
The method
get_dbt_datasetno longer exists. It used to exist in older versions of Cosmos (before 1.1) when the URIs respected the format:Dataset(f"DBT://{connection_id.upper()}/{project_name.upper()}/{model_name.upper()}")More information on why we changed this: #305
Closes: #1032