Fix rendering detached tests in TestBehavior.NONE and AFTER_ALL
#1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of #1433 (Cosmos 1.8.1), we introduced a bug: detached test nodes were being incorrectly displayed when using: - `TestBehavior.NONE` (when no tests should be run) - `TestBehavior.AFTER_ALL` (when all tests should be run by the end of the DAG, regardless of their type) This PR solves this issue. Closes: #1444
dosubot
bot
added
the
size:L
Deploying astronomer-cosmos with
|
| Latest commit: |
d6b3823
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9355405b.astronomer-cosmos.pages.dev |
| Branch Preview URL: | https://issue-1444.astronomer-cosmos.pages.dev |
✅ Deploy Preview for sunny-pastelito-5ecb04 canceled.
|
dosubot
bot
added
area:rendering
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1463 +/- ##
=======================================
Coverage 96.94% 96.94%
=======================================
Files 73 73
Lines 4355 4359 +4
=======================================
+ Hits 4222 4226 +4
Misses 133 133 ☔ View full report in Codecov by Sentry. |
Merged
pankajkoti
approved these changes
Jan 15, 2025
tatiana
added a commit
that referenced
this pull request
Jan 15, 2025
Bug Fixes * Fix ``httpx.get`` exception handling while emitting telemetry by @tatiana in #1439 * Fix (not) rendering detached tests in ``TestBehavior.NONE`` and ``AFTER_ALL`` by @tatiana in #1463 * Fix detached test tasks names so they do not exceed 250 chars by @tatiana in #1464 Enhancement * Allow users to opt-in or out (default) of detached test nodes by @tatiana in #1470. Learn more about this [here](https://astronomer.github.io/astronomer-cosmos/configuration/testing-behavior.html). Docs * Docs: Fix broken links and rendering by @pankajastro in #1437 * Update ``operator args`` docs to include ``install_deps`` by @tatiana in #1456 * Improve Cosmos ``select`` docs to include latest graph operator support by @tatiana in #1467 Others * Upgrade GitHub action artifacts upload-artifact & download-artifact to v4 by @pankajkoti in #1445 * Enable Depandabot to scan outdated Github Actions dependencies by @tatiana in #1446 * Pre-commit hook updates in #1459, #1441 * Dependabot Github action updates in #1451, #1452, #1453, #1454, #1455
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #1433 (Cosmos 1.8.1), we introduced a bug: detached test nodes were being incorrectly displayed when using:
TestBehavior.NONE(when no tests should be run)TestBehavior.AFTER_ALL(when all tests should be run by the end of the DAG, regardless of their type)This PR solves this issue.
Closes: #1444