update graph parsing mode when virtualenv is selected #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for amazing-pothos-a3bca0 processing.
|
CorsettiS
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #402 +/- ##
=======================================
Coverage 79.36% 79.36%
=======================================
Files 48 48
Lines 1691 1691
=======================================
Hits 1342 1342
Misses 349 349
☔ View full report in Codecov by Sentry. |
jlaneve
approved these changes
Jul 27, 2023
tatiana
pushed a commit
that referenced
this pull request
Aug 9, 2023
## Description When using a virtualenv to run our dbt tasks, we are working under the hypothesis that dbt is not installed in the machine. However as of now, if we choose virtualenv as the execution mode, dbt tries to parse the graph of the dbt tasks with **load_via_dbt_ls()**, while it should point out to **load_via_custom_parser()** due to the fact aforementioned. we can accomplish it by removing the virutalenv executor from the _elif_ condition for **load_via_dbt_ls()**, so it will be picked up automatically by the _else_ condition. ## Related Issue(s) closes #401 ## Breaking Change? No. it worked fine in the dev sandbox, although I did not have the opportunity to test it with any image without dbt pre-installed. Obs: I had to change also the tests for this change ## Checklist - [X] I have made corresponding changes to the documentation (if required) - [ ] I have added tests that prove my fix is effective or that my feature works --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Julian LaNeve <lanevejulian@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using a virtualenv to run our dbt tasks, we are working under the hypothesis that dbt is not installed in the machine. However as of now, if we choose virtualenv as the execution mode, dbt tries to parse the graph of the dbt tasks with load_via_dbt_ls(), while it should point out to load_via_custom_parser() due to the fact aforementioned. we can accomplish it by removing the virutalenv executor from the elif condition for load_via_dbt_ls(), so it will be picked up automatically by the else condition.
Related Issue(s)
closes #401
Breaking Change?
No. it worked fine in the dev sandbox, although I did not have the opportunity to test it with any image without dbt pre-installed.
Obs: I had to change also the tests for this change
Checklist