Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: use temp dir for test_load_via_dbt_ls_without_dbt_deps_and_preinstalled_dbt_packages #748

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

jbandoro
Copy link
Collaborator

@jbandoro jbandoro commented Dec 5, 2023

Description

This is a follow up to #730 so that the fixture tmp_dbt_project_dir is used for the test instead of the actual project directory since it installs dbt packages that need to be cleaned up.

Related Issue(s)

None

Breaking Change?

None

Checklist

  • I have made corresponding changes to the documentation (if required)
  • I have added tests that prove my fix is effective or that my feature works

@jbandoro jbandoro requested a review from a team as a code owner December 5, 2023 21:59
@jbandoro jbandoro requested a review from a team December 5, 2023 21:59
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Dec 5, 2023
Copy link

netlify bot commented Dec 5, 2023

👷 Deploy Preview for amazing-pothos-a3bca0 processing.

Name Link
🔨 Latest commit 261f7d0
🔍 Latest deploy log https://app.netlify.com/sites/amazing-pothos-a3bca0/deploys/656f9d31206dc00008875e6f

@dosubot dosubot bot added area:testing Related to testing, like unit tests, integration tests, etc dbt:test Primarily related to dbt test command or functionality parsing:dbt_ls Issues, questions, or features related to dbt_ls parsing labels Dec 5, 2023
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2988649) 93.13% compared to head (261f7d0) 93.13%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #748   +/-   ##
=======================================
  Coverage   93.13%   93.13%           
=======================================
  Files          55       55           
  Lines        2431     2431           
=======================================
  Hits         2264     2264           
  Misses        167      167           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@tatiana tatiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, @jbandoro !

@tatiana tatiana merged commit 3bc60a9 into astronomer:main Dec 6, 2023
40 checks passed
@tatiana tatiana added this to the 1.3.0 milestone Dec 13, 2023
arojasb3 pushed a commit to arojasb3/astronomer-cosmos that referenced this pull request Jul 14, 2024
…einstalled_dbt_packages` (astronomer#748)

This is a follow up to astronomer#730 so that the fixture `tmp_dbt_project_dir` is
used for the test instead of the actual project directory since it
installs dbt packages that need to be cleaned up.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:testing Related to testing, like unit tests, integration tests, etc dbt:test Primarily related to dbt test command or functionality parsing:dbt_ls Issues, questions, or features related to dbt_ls parsing size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants