Fix manifest testing behavior #955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
✅ Deploy Preview for sunny-pastelito-5ecb04 canceled.
|
dosubot
bot
added
the
area:testing
tatiana
reviewed
May 13, 2024
There was a problem hiding this comment.
Thanks a lot for working on this fix, @chris-okorodudu !
It seems some of the tests are breaking, such as:
+ where {'/home/runner/work/astronomer-cosmos/astronomer-cosmos/dev/dags/example_virtualenv.py': 'Traceback (most recent call ...ate_node_dependency\n for _, node in self.nodes.items():\nRuntimeError: dictionary changed size during iteration\n'} =
Could you fix this, please?
Yes definitely I'll try to take a look later today |
closes: astronomer#952 This PR addresses the following issues: **1. Pre-commit Setup:** - Pre-commit was not running in the CI pipeline because it was neither configured for this repository nor were we using the pre-commit command in CI to run it manually. To fix this: Installed and added pre-commit to this repository. This allows pre-commit to automatically run the pre-commit configuration on every push. **2. Type Check Job:** - Previously, the type-check job was running with mypy directly, and the pre-commit type check command had different configurations. This PR aligns the configurations. **3. Type Check Fixes:** - Ignored the type check for __dataclass_fields__ since mypy seems to not recognize it. - Added a check for None for ti.task
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #955 +/- ##
=======================================
Coverage 95.69% 95.69%
=======================================
Files 59 59
Lines 2879 2880 +1
=======================================
+ Hits 2755 2756 +1
Misses 124 124 ☔ View full report in Codecov by Sentry. |
tatiana
approved these changes
May 15, 2024
Merged
arojasb3
pushed a commit
to arojasb3/astronomer-cosmos
that referenced
this pull request
Jul 14, 2024
Updating the update_node_dependency method to ensure all relevant test nodes are included in the airflow graph. This fix stems from the test nodes not being included in the filtered_nodes dict after the select_nodes method is used to do filtering by graph operator. Closes: astronomer#949
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating the update_node_dependency method to ensure all relevant test nodes are included in the airflow graph. This fix stems from the test nodes not being included in the filtered_nodes dict after the select_nodes method is used to do filtering by graph operator.
Related Issue(s)
#949
Breaking Change?
Checklist