Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update emeritus contributors list #961

Merged
merged 2 commits into from
May 15, 2024
Merged

Update emeritus contributors list #961

merged 2 commits into from
May 15, 2024

Conversation

tatiana
Copy link
Collaborator

@tatiana tatiana commented May 14, 2024

There have been people who had a major role in the creation and/or development of Cosmos in previous phases, but for different circumstances, they have not been able to continue contributing to it in more recent times. This is not only from a code perspective, but also from a community perspective:

Screenshot 2024-05-14 at 11 38 12 Screenshot 2024-05-14 at 11 38 03

With this change, we recognize their contributions. If, in the future, they start to contribute again to the project, we'll move them to the contributions section again, regaining committer superpowers.

More information in the contributors roles can be found at: https://github.com/astronomer/astronomer-cosmos/blob/main/docs/contributors-roles.rst

Copy link

netlify bot commented May 14, 2024

Deploy Preview for sunny-pastelito-5ecb04 ready!

Name Link
🔨 Latest commit f834722
🔍 Latest deploy log https://app.netlify.com/sites/sunny-pastelito-5ecb04/deploys/6644b26bae1fe900083eb8d1
😎 Deploy Preview https://deploy-preview-961--sunny-pastelito-5ecb04.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@d791d20). Click here to learn what that means.

❗ Current head e65762c differs from pull request most recent head f834722. Consider uploading reports for the commit f834722 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #961   +/-   ##
=======================================
  Coverage        ?   95.72%           
=======================================
  Files           ?       59           
  Lines           ?     2877           
  Branches        ?        0           
=======================================
  Hits            ?     2754           
  Misses          ?      123           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tatiana tatiana marked this pull request as ready for review May 14, 2024 10:57
@tatiana tatiana requested a review from a team as a code owner May 14, 2024 10:57
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. area:docs Relating to documentation, changes, fixes, improvement labels May 14, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 14, 2024
@ashb
Copy link

ashb commented May 15, 2024

I'm not so sure that Harel should have this status -- he hasn't contributed directly to the project much. My understanding was his involvement was because he was a team lead and someone had to review things. (I don't mind it, it just feels odd for 4 small commits.)

@tatiana
Copy link
Collaborator Author

tatiana commented May 15, 2024

I'm not so sure that Harel should have this status -- he hasn't contributed directly to the project much. My understanding was his involvement was because he was a team lead, and someone had to review things. (I don't mind it, it just feels odd for 4 small commits.)

Thanks a lot, @ashb , for your thoughts on this! I addressed the feedback in fb2fcc4, and I'll merge this. If we believe we were unfair in the future, we can always revisit this.

@tatiana tatiana merged commit b3216eb into main May 15, 2024
66 checks passed
@tatiana tatiana deleted the update-emeritus branch May 15, 2024 13:08
@tatiana tatiana mentioned this pull request May 16, 2024
arojasb3 pushed a commit to arojasb3/astronomer-cosmos that referenced this pull request Jul 14, 2024
There have been people who had a major role in the creation and/or
development of Cosmos in previous phases, but for different
circumstances, they have not been able to continue contributing to it in
more recent times. This is not only from a code perspective, but also
from a community perspective:

<img width="410" alt="Screenshot 2024-05-14 at 11 38 12"
src="https://github.com/astronomer/astronomer-cosmos/assets/272048/c8312fcb-db7d-44bf-b18a-a5867dbbbb4e">
<img width="413" alt="Screenshot 2024-05-14 at 11 38 03"
src="https://github.com/astronomer/astronomer-cosmos/assets/272048/48e43f7d-9625-4139-a4b3-5c2b4b92662e">

With this change, we recognize their contributions. If, in the future,
they start to contribute again to the project, we'll move them to the
contributions section again, regaining committer superpowers.

More information in the contributors roles can be found at:
https://github.com/astronomer/astronomer-cosmos/blob/main/docs/contributors-roles.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:docs Relating to documentation, changes, fixes, improvement lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants