-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update emeritus contributors list #961
Conversation
✅ Deploy Preview for sunny-pastelito-5ecb04 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #961 +/- ##
=======================================
Coverage ? 95.72%
=======================================
Files ? 59
Lines ? 2877
Branches ? 0
=======================================
Hits ? 2754
Misses ? 123
Partials ? 0 ☔ View full report in Codecov by Sentry. |
I'm not so sure that Harel should have this status -- he hasn't contributed directly to the project much. My understanding was his involvement was because he was a team lead and someone had to review things. (I don't mind it, it just feels odd for 4 small commits.) |
Thanks a lot, @ashb , for your thoughts on this! I addressed the feedback in fb2fcc4, and I'll merge this. If we believe we were unfair in the future, we can always revisit this. |
There have been people who had a major role in the creation and/or development of Cosmos in previous phases, but for different circumstances, they have not been able to continue contributing to it in more recent times. This is not only from a code perspective, but also from a community perspective: <img width="410" alt="Screenshot 2024-05-14 at 11 38 12" src="https://github.com/astronomer/astronomer-cosmos/assets/272048/c8312fcb-db7d-44bf-b18a-a5867dbbbb4e"> <img width="413" alt="Screenshot 2024-05-14 at 11 38 03" src="https://github.com/astronomer/astronomer-cosmos/assets/272048/48e43f7d-9625-4139-a4b3-5c2b4b92662e"> With this change, we recognize their contributions. If, in the future, they start to contribute again to the project, we'll move them to the contributions section again, regaining committer superpowers. More information in the contributors roles can be found at: https://github.com/astronomer/astronomer-cosmos/blob/main/docs/contributors-roles.rst
There have been people who had a major role in the creation and/or development of Cosmos in previous phases, but for different circumstances, they have not been able to continue contributing to it in more recent times. This is not only from a code perspective, but also from a community perspective:
With this change, we recognize their contributions. If, in the future, they start to contribute again to the project, we'll move them to the contributions section again, regaining committer superpowers.
More information in the contributors roles can be found at: https://github.com/astronomer/astronomer-cosmos/blob/main/docs/contributors-roles.rst