Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add static check #231

Merged
merged 3 commits into from
Oct 9, 2024
Merged

Add static check #231

merged 3 commits into from
Oct 9, 2024

Conversation

pankajastro
Copy link
Contributor

@pankajastro pankajastro commented Oct 9, 2024

Add a GitHub action job to run static checks and lint for the project.

  • Add pre-commit hooks (pre-commit-hooks, ruff, black)
  • Expose hatch command to run it in CI as well as local
    Example: hatch run tests.py3.12-2.10:static-check

closes: #196

.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@tatiana tatiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a great addition, @pankajastro. This change will help us maintain the code quality! Thank you!

@tatiana tatiana merged commit 7a9b420 into main Oct 9, 2024
8 checks passed
@pankajastro pankajastro deleted the pre-commit branch October 9, 2024 13:23
Copy link
Contributor

@pankajkoti pankajkoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change, thanks @pankajastro 👏🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pre-commit config and run it in CI
3 participants