Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Makefile to run make docker-run #271

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Fix Makefile to run make docker-run #271

merged 1 commit into from
Oct 22, 2024

Conversation

tatiana
Copy link
Collaborator

@tatiana tatiana commented Oct 22, 2024

Fixes the following errors that popped up when trying to run make docker-run:

(venv) ➜  dag-factory git:(release-0.2.0) ✗ make build-whl
cd examples && ln -s ../dev/dags dags
ln: dags/dags: File exists
make: *** [build-whl] Error 1

And

(venv) ➜  dag-factory git:(release-0.2.0) ✗ make docker-run 
cd dev
python3 -m build --outdir dev/include/
/Users/tati/Code/dag-factory/venv/bin/python3: No module named build
make: *** [build-whl] Error 1

Copy link
Contributor

@pankajkoti pankajkoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, Tatiana!

@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.96%. Comparing base (dfd46b8) to head (06042c7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #271   +/-   ##
=======================================
  Coverage   93.96%   93.96%           
=======================================
  Files           8        8           
  Lines         630      630           
=======================================
  Hits          592      592           
  Misses         38       38           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tatiana tatiana merged commit a947aa8 into main Oct 22, 2024
67 checks passed
@tatiana tatiana deleted the fix-makefile branch October 22, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants