Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up infrastructure #134

Merged
merged 21 commits into from
Nov 22, 2019
Merged

Clean up infrastructure #134

merged 21 commits into from
Nov 22, 2019

Conversation

astrofrog
Copy link
Member

This updates the package infrastructure to the latest version of the package template

I've also added setup_requires which was missing and should have been set to Numpy.

Fixes #129

@astrofrog
Copy link
Member Author

The 32-bit CI failure can be ignored, it's the usual issue that CircleCI doesn't seem to notice submodule updates (astropy-helpers) in forks. It should work properly once merged in.

@coveralls
Copy link

coveralls commented Nov 21, 2019

Coverage Status

Coverage remained the same at 94.538% when pulling e019283 on astrofrog:cleanup into a659447 on astropy:master.

@astrofrog
Copy link
Member Author

I have to pin hypothesis due to #135

@astrofrog astrofrog requested a review from cdeil November 21, 2019 16:57
@astrofrog
Copy link
Member Author

@cdeil - any objections to this if CI passes? (feel free to review in more detail if you like, but this is mostly just updating files based on the template)

Copy link
Member

@cdeil cdeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@astrofrog astrofrog merged commit 0d56279 into astropy:master Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ModuleNotFoundError numpy on pip install
3 participants