Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP: drop dangling runtime dependency on setuptools #36

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

neutrinoceros
Copy link

Found by running the following command from astropy/:

❯ uv tree --package setuptools --invert
Resolved 166 packages in 11ms
asdf-astropy v0.7.0
├── astropy v7.1.dev253+g4a55b10002 (extra: all)
│   └── asdf-astropy v0.7.0 (*)
├── astropy v7.1.dev253+g4a55b10002 (extra: dev-all) (*)
└── astropy v7.1.dev253+g4a55b10002 (extra: test-all) (*)
setuptools v75.6.0
└── astropy-sphinx-theme v1.1
    └── sphinx-astropy v1.9.1
        ├── astropy[confv2] v7.1.dev253+g4a55b10002 (extra: dev) (*)
        ├── astropy[confv2] v7.1.dev253+g4a55b10002 (extra: dev-all) (*)
        └── astropy[confv2] v7.1.dev253+g4a55b10002 (extra: docs) (*)

I find that this package doesn't actually require setuptools at runtime, so I assume it was listed by mistake when it should only have been a build-time requirement.

@neutrinoceros neutrinoceros marked this pull request as ready for review December 5, 2024 14:22
@neutrinoceros neutrinoceros force-pushed the dep/drop_unused_runtime_setuptools branch from ac3173b to 2dc3c9b Compare December 5, 2024 14:24
Comment on lines -24 to -25
install_requires =
setuptools>=30.3.0
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be clear; only this part is problematic, setup_requires is fine in itself, but it's still redundant with pyproject.toml and should not be needed at all with python_requires = >=3.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant