Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI tests to build notebooks can pass even if notebooks fail #611

Closed
jeffjennings opened this issue Oct 10, 2024 · 0 comments · Fixed by #612
Closed

CI tests to build notebooks can pass even if notebooks fail #611

jeffjennings opened this issue Oct 10, 2024 · 0 comments · Fixed by #612

Comments

@jeffjennings
Copy link
Contributor

jeffjennings commented Oct 10, 2024 •
edited
Loading

prs.yml passes even if processes in bash loop(s) within Makefile fail. These loops should be updated to throw an error when a notebook build or convert (or dependency install) fails.

Fixed with set -e line in bash loops - see https://unix.stackexchange.com/a/340652 https://github.com/orgs/community/discussions/26710
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Catch build failures in Makefile jeffjennings/astropy-tutorials
1 participant
@jeffjennings