Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch build failures in Makefile #612

Merged
merged 8 commits into from
Oct 29, 2024
Merged

Catch build failures in Makefile #612

merged 8 commits into from
Oct 29, 2024

Conversation

jeffjennings
Copy link
Contributor

@jeffjennings jeffjennings commented Oct 10, 2024 •
edited
Loading

Ensures the CI workflows calling make fail if commands in the bash calls in Makefile raise an error.

I checked that the CI correctly fails when the bash loop encounters errors in either execute or convert.

Closes #611

  • Check the box to confirm that you are familiar with the contributing guidelines and/or indicate (check the box) that you are familiar with our contributing workflow.
  • Confirm that any contributed tutorials contain a complete Introduction which includes an Author list, Learning Goals, Keywords, Companion Content (if applicable), and a Summary.
  • Check the box to confirm that you are familiar with the Astropy community code of conduct and you agree to follow the CoC.

@jeffjennings jeffjennings added Run all tutorials Tells the GitHub actions CI to run all tutorials in the repo (vs. only modified ones) and removed Run all tutorials Tells the GitHub actions CI to run all tutorials in the repo (vs. only modified ones) labels Oct 10, 2024
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@jeffjennings jeffjennings added the Run all tutorials Tells the GitHub actions CI to run all tutorials in the repo (vs. only modified ones) label Oct 10, 2024
@jeffjennings jeffjennings requested a review from adrn October 10, 2024 20:16
adrn
adrn approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@adrn adrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@adrn adrn merged commit e7d20e1 into astropy:main Oct 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrn adrn adrn approved these changes

Assignees
No one assigned
Labels
Run all tutorials Tells the GitHub actions CI to run all tutorials in the repo (vs. only modified ones)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI tests to build notebooks can pass even if notebooks fail
2 participants
@jeffjennings @adrn