-
-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add CelestialCoord1 tutorial notebook [new content] #436
Conversation
A Google Colab version will follow soon and be posted here. |
Google Colab link for |
An error encountered during the CircleCI build that is unrelated to this notebook in particular as follows:
|
The failure was related to this issue, should now be resolved with reproject v0.7 astropy/reproject#224 |
At the Learn telecon today, we decided this notebook should be longer, including reading in a FITS file of the Helix Nebula, and plotting it with coordinates labeled on the axes, and then to stop at that point. |
Please consider also Issue #443 |
@eblur @kelle @stargaser The Colab version of the 1st WCS tutorial is ready for another (possibly a final) review: https://colab.research.google.com/drive/14ZN73gO9aIiqX-bd8PsXuBxGspO-6eOQ?usp=sharing Once I get a final approval (expecting mostly from @eblur) then I will move the code into the repo via |
Hi @kakirastern I finished reviewing the Colab notebook. I made some minor grammatical changes and moved some of the text around for ease of reading. After one minor change needed on your part, I think it's good to go! Please:
|
I saw in this Slack thread that specutils puts test files in Zenodo. Perhaps something to consider for the data file here? From the Slack post, there is some relevant specutils code that could be used as a template. |
Thanks @eblur! I will make the final change according to your suggestion soon and push it to the repo via Git. |
Yeah @stargaser I think that would be a good option to explore since we might have more control over the data files via Zenodo. I will put this in the running notes at the next telecon/co-work hour so we could have some discussion regarding the matter. |
Fixes #443.
Address #400, though not completely fixing it.
Add new FITS World Coordinate System (WCS) tutorial to guide users on how to building one's own
astropy.wcs.WCS
object, serving as an intro to WCS usingastropy
in two ways programmatically.