-
-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to using nbcollection + github actions #495
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Oops, I think I need to first add a workflow in |
Note: there are real failures in the conesearch tutorial because of an issue with the VO server (comments by @pllim in slack). In the long run, we still need to implement a more robust solution for handling remote data. One idea would be to distribute the |
@jonathansick I think this is now a working proof of concept! Here is the resulting artifact / zip file of the rendered tutorials: https://github.com/astropy/astropy-tutorials/suites/3848792615/artifacts/95489955 |
(Tried to get the circleci error to go away, because I removed the webhook, but no luck...) |
@adrn This looks great. Since this doesn't affect the current production (afaik), this should be safe to merge now and I'll contribute the cross-deploy into the astropy/learn-astropy repo. I might need to adjust some of the CSS selectors in astropy/learn-astropy-librarian in order to gather the new notebooks since they aren't wrapped in the Sphinx HTML structure anymore. That shouldn't be an issue, though. |
Great! OK I'll do it then - #yolo |
Demonstration of switching the execute & convert machinery to nbcollection with github actions instead of custom scripts + circleCI.