Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using nbcollection + github actions #495

Merged
merged 28 commits into from
Sep 24, 2021
Merged

Conversation

adrn
Copy link
Member

@adrn adrn commented Sep 21, 2021

Demonstration of switching the execute & convert machinery to nbcollection with github actions instead of custom scripts + circleCI.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@adrn
Copy link
Member Author

adrn commented Sep 21, 2021

Oops, I think I need to first add a workflow in main to get it to see the new workflow...

@adrn adrn closed this Sep 21, 2021
@adrn adrn reopened this Sep 21, 2021
@adrn
Copy link
Member Author

adrn commented Sep 22, 2021

Note: there are real failures in the conesearch tutorial because of an issue with the VO server (comments by @pllim in slack). In the long run, we still need to implement a more robust solution for handling remote data. One idea would be to distribute the ~/.astropy/cache needed by the tutorials with this repo so that CI doesn't do any remote data access. In the short term, we might want to just skip the conesearch tutorial in the build process...

@adrn
Copy link
Member Author

adrn commented Sep 23, 2021

@jonathansick I think this is now a working proof of concept! Here is the resulting artifact / zip file of the rendered tutorials: https://github.com/astropy/astropy-tutorials/suites/3848792615/artifacts/95489955
Should we merge this and have you add the cross-deploy in a separate PR?

@adrn adrn changed the title [WIP] Switch to using nbcollection + github actions Switch to using nbcollection + github actions Sep 23, 2021
@adrn adrn closed this Sep 23, 2021
@adrn adrn reopened this Sep 23, 2021
@adrn
Copy link
Member Author

adrn commented Sep 23, 2021

(Tried to get the circleci error to go away, because I removed the webhook, but no luck...)

@jonathansick
Copy link
Contributor

@adrn This looks great. Since this doesn't affect the current production (afaik), this should be safe to merge now and I'll contribute the cross-deploy into the astropy/learn-astropy repo.

I might need to adjust some of the CSS selectors in astropy/learn-astropy-librarian in order to gather the new notebooks since they aren't wrapped in the Sphinx HTML structure anymore. That shouldn't be an issue, though.

@adrn
Copy link
Member Author

adrn commented Sep 24, 2021

Great! OK I'll do it then - #yolo

@adrn adrn merged commit 2d24517 into astropy:main Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants