Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes for data downloads in specutils analysis notebooks #241

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Bugfixes for data downloads in specutils analysis notebooks #241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1014df
bugfixes for data downloads in specutils analysis notebooks
bmorris3 Jul 22, 2024
ff9e433
minpin latest specutils
bmorris3 Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion 00-Install_and_Setup/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@ asdf
asdf-astropy
gwcs>=0.20
photutils>=1.10.0
specutils>=1.12.0
specutils>=1.18.0
astroquery>=0.4.7dev9008
openpyxl
17 changes: 12 additions & 5 deletions 09b-Specutils/Specutils_analysis.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
"source": [
"## Sample Spectrum and SNR\n",
"\n",
"For use below, we also load the sample SDSS spectrum downloaded in the [overview notebook](Specutils_overview.ipynb). See that notebook if you have not yet downloaded this spectrum."
"For use below, we also load the sample SDSS spectrum downloaded in the [overview notebook](Specutils_overview.ipynb)."
]
},
{
Expand All @@ -71,7 +71,14 @@
"metadata": {},
"outputs": [],
"source": [
"sdss_spec = Spectrum1D.read('data/sdss_spectrum.fits', format='SDSS-III/IV spec')\n",
"from urllib.request import urlretrieve\n",
"\n",
"sdss_spectrum_path = 'data/sdss_spectrum.fits'\n",
"\n",
"url = 'https://data.sdss.org/sas/dr16/sdss/spectro/redux/26/spectra/1323/spec-1323-52797-0012.fits'\n",
"urlretrieve(url, sdss_spectrum_path)\n",
"\n",
"sdss_spec = Spectrum1D.read(sdss_spectrum_path, format='SDSS-III/IV spec')\n",
"plt.step(sdss_spec.wavelength, sdss_spec.flux);"
]
},
Expand Down Expand Up @@ -660,7 +667,7 @@
],
"metadata": {
"kernelspec": {
"display_name": "Python 3",
"display_name": "Python 3 (ipykernel)",
"language": "python",
"name": "python3"
},
Expand All @@ -674,7 +681,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.8.5"
"version": "3.11.5"
},
"toc": {
"base_numbering": 1,
Expand All @@ -691,5 +698,5 @@
}
},
"nbformat": 4,
"nbformat_minor": 2
"nbformat_minor": 4
}
18 changes: 16 additions & 2 deletions 09b-Specutils/Specutils_analysis_solutions.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,14 @@
"metadata": {},
"outputs": [],
"source": [
"sdss_spec = Spectrum1D.read('data/sdss_spectrum.fits', format='SDSS-III/IV spec')\n",
"from urllib.request import urlretrieve\n",
"\n",
"sdss_spectrum_path = 'data/sdss_spectrum.fits'\n",
"\n",
"url = 'https://data.sdss.org/sas/dr16/sdss/spectro/redux/26/spectra/1323/spec-1323-52797-0012.fits'\n",
"urlretrieve(url, sdss_spectrum_path)\n",
"\n",
"sdss_spec = Spectrum1D.read(sdss_spectrum_path, format='SDSS-III/IV spec')\n",
"plt.step(sdss_spec.wavelength, sdss_spec.flux);"
]
},
Expand Down Expand Up @@ -850,6 +857,13 @@
"# huzzah! the fit gives a pretty close answer given the noise\n",
"gmodel, full_spec_model.left"
]
},
{
"cell_type": "code",
"execution_count": null,
"metadata": {},
"outputs": [],
"source": []
}
],
"metadata": {
Expand All @@ -868,7 +882,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.11.6"
"version": "3.11.5"
},
"toc": {
"base_numbering": 1,
Expand Down