Enable calling Gaia.query_object() with both columns and radius
#2249
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2249 +/- ##
=======================================
Coverage 62.60% 62.60%
=======================================
Files 131 131
Lines 16784 16784
=======================================
Hits 10508 10508
Misses 6276 6276
Continue to review full report at Codecov.
|
eerovaher
force-pushed
the
gaia-object-radius-columns
branch
from
ecf8cf3 to
d21bcd3
Compare
|
This wasn't included in the 0.4.5 release, so I had to rebase to update the change log entry. |
Currently the `astroquery.gaia.core.GaiaClass.query_object()` method ignores the `column` argument if `radius` is specified. This commit adds a remote test that reveals the problem.
The method `astroquery.gaia.core.GaiaClass.__query_object()` no longer ignores its `column` argument when `radius` is specified.
eerovaher
force-pushed
the
gaia-object-radius-columns
branch
from
d21bcd3 to
252b116
Compare
|
I had to rebase to avoid another merge conflict in the change log. |
|
The CI failure is unrelated to the changes implemented here, see astropy/pyvo#288. Should I update this pull request to restart the tests or is this good to go with the CI results being what they are? |
|
I just restarted the jobs - they should work now that there is a released pyvo w/the corrected namespace |
|
@bsipocz, could you review this? |
|
Thanks @eerovaher ! |
Currently
Gaia.query_object()andGaia.query_object_async()ignore theircolumnsargument ifradiusis specified. This pull request provides the bugfix.Fixes #2025