MNT: last of the python2 cleanups #2392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using this darling: gsed -i -e 's|\(.*super(\)\(.*)\.\)\(.*)\)|\1).\3|g'
Codecov Report
@@ Coverage Diff @@
## main #2392 +/- ##
=======================================
Coverage 62.87% 62.87%
=======================================
Files 133 133
Lines 17246 17246
=======================================
Hits 10844 10844
Misses 6402 6402
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
eerovaher
reviewed
May 5, 2022
| @@ -3,7 +3,7 @@ | |||
| __all__ = ['DummyHandler'] | |||
|
|
|||
|
|
|||
| class DummyHandler(object): | |||
| class DummyHandler(): | |||
There was a problem hiding this comment.
The following would be equivalent, but shorter:
Suggested change
| class DummyHandler(): | |
| class DummyHandler: |
eerovaher
reviewed
May 5, 2022
astroquery/query.py
Outdated
| @@ -114,7 +114,7 @@ def from_cache(self, cache_location): | |||
| response = pickle.load(f) | |||
| if not isinstance(response, requests.Response): | |||
| response = None | |||
| except IOError: # TODO: change to FileNotFoundError once drop py2 support | |||
| except OSError: # TODO: change to FileNotFoundError once drop py2 support | |||
There was a problem hiding this comment.
The comment here suggests using a more specific subclass of OSError, it might be a good idea to do the same elsewhere too.
There was a problem hiding this comment.
Hah, sed doesn't read the comments :)
|
I'm addressing the URL sanitizing issue separately in #2394 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to close #1870