Esa hst fixing tests #2461
Merged
Esa hst fixing tests #2461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2461 +/- ##
=======================================
Coverage 62.92% 62.92%
=======================================
Files 133 133
Lines 17300 17300
=======================================
Hits 10886 10886
Misses 6414 6414 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
This was
linked to
issues
Jul 11, 2022
bsipocz
approved these changes
Jul 11, 2022
| @@ -103,7 +102,7 @@ def test_hap_composite_to_hap_simple(self): | |||
| def test_hap_simple_to_hap_composite(self): | |||
| esa_hubble = ESAHubble() | |||
| result = esa_hubble.get_member_observations('hst_16316_71_acs_sbc_f150lp_jec071i9') | |||
| assert result == ['hst_16316_71_acs_sbc_f150lp_jec071'] | |||
| assert result == [' hst_16316_71_acs_sbc_total_jec071', 'hst_16316_71_acs_sbc_f150lp_jec071'] | |||
There was a problem hiding this comment.
indeed the space is necessary, however, that is a big weird behaviour, is it maybe a bug @javier-ballester
CHANGES.rst
Outdated
| hst | ||
| ^^^ | ||
|
|
||
| - Fixed failing hst remote tests [#2461] |
There was a problem hiding this comment.
no changelog is needed for non user-facing changes or documentation only PRs
|
Actually, this doesn't address #2107, the temp files are still dumped into the main directory after running pytest, so I keep that issue open, but go ahead and merge the PR as it indeed addresses the failing tests. |
bsipocz
force-pushed
the
ESA_HST_fixing_tests
branch
from
fa74b15 to
c5a9543
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Astroquery team,
These changes have been made to fix issues 2107 and 2359.
Kind regards,
@esdc-esac-esa-int