Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: adding py311 testing #2627

Merged
merged 4 commits into from
Dec 12, 2022
Merged

MAINT: adding py311 testing #2627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2bd7d6a
MAINT: adding deprecationwarning to ignore for direct pytest runs (to…
bsipocz Dec 12, 2022
56a3c91
CI: adding python 3.11 testing
bsipocz Dec 12, 2022
be0c091
MAINT: working around ValueError (somehow new for random.choice)
bsipocz Dec 12, 2022
e480901
MAINT: ignore cgi deprecation for now
bsipocz Dec 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/ci_crontests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@ jobs:
fail-fast: false
matrix:
include:
- name: py3.10 all dev deps online
- name: py3.11 all dev deps online
os: ubuntu-latest
python: '3.10'
toxenv: py310-test-alldeps-devdeps-online
python: '3.11'
toxenv: py311-test-alldeps-devdeps-online
toxargs: -v
toxposargs: -v --durations=50

Expand All @@ -36,10 +36,10 @@ jobs:
toxargs: -v
toxposargs: -v --durations=50

- name: py3.10 pre-release all deps
- name: py3.11 pre-release all deps
os: ubuntu-latest
python: '3.10'
toxenv: py310-test-alldeps-predeps
python: '3.11'
toxenv: py311-test-alldeps-predeps
toxargs: -v
toxposargs: -v

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ci_devtests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ jobs:
include:
- name: dev dependencies with all dependencies with coverage
os: ubuntu-latest
python: '3.10'
toxenv: py310-test-alldeps-devdeps-cov
python: '3.11'
toxenv: py311-test-alldeps-devdeps-cov
toxargs: -v

steps:
Expand Down
6 changes: 3 additions & 3 deletions astroquery/esa/hubble/tests/test_esa_hubble_remote.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@
import tempfile

import os
import numpy as np

import pytest
from astroquery.esa.hubble import ESAHubble
from astropy import coordinates
import random

esa_hubble = ESAHubble()

Expand Down Expand Up @@ -58,7 +58,7 @@ def test_query_tap_async(self):

def test_download_product(self):
result = esa_hubble.query_tap(query=self.hst_query)
observation_id = random.choice(result['observation_id'])
observation_id = np.random.choice((result['observation_id']))
temp_file = self.temp_folder.name + "/" + observation_id + ".tar"
esa_hubble.download_product(observation_id=observation_id,
filename=temp_file)
Expand All @@ -67,7 +67,7 @@ def test_download_product(self):
def test_get_artifact(self):
result = esa_hubble.query_tap(query=self.top_artifact_query)
assert "artifact_id" in result.keys()
artifact_id = random.choice(result["artifact_id"])
artifact_id = np.random.choice(result["artifact_id"])
temp_file = self.temp_folder.name + "/" + artifact_id + ".gz"
esa_hubble.get_artifact(artifact_id=artifact_id, filename=temp_file)
assert os.path.exists(temp_file)
Expand Down
4 changes: 4 additions & 0 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@ filterwarnings =
# These are temporary measures, all of these should be fixed:
# -----------------------------------------------------------
ignore:distutils Version classes are deprecated:DeprecationWarning
# Remove along with astropy-helpers, once we switch to a new versioning scheme
ignore:Use setlocale:DeprecationWarning
# Remove with fix for https://github.com/astropy/astroquery/issues/2628
ignore:\'cgi\' is deprecated and:DeprecationWarning
# Upstream issues in many packages, not clear whether we can do anything about these in astroquery
ignore:unclosed <socket.socket:ResourceWarning
ignore:unclosed <ssl.SSLSocket:ResourceWarning
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tox]
envlist =
py{37,38,39,310}-test{,-alldeps,-oldestdeps,-devdeps,-predeps}{,-online}{,-cov}
py{37,38,39,310,311}-test{,-alldeps,-oldestdeps,-devdeps,-predeps}{,-online}{,-cov}
codestyle
linkcheck
build_docs
Expand Down