ALMA: auth handling to login to Keycloak #2712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2712 +/- ##
==========================================
+ Coverage 65.87% 66.05% +0.17%
==========================================
Files 233 233
Lines 17904 17925 +21
==========================================
+ Hits 11794 11840 +46
+ Misses 6110 6085 -25
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@andamian could you provide the review for this one? It looks good to me but I haven't tested and I know nothing about the ALMA login protocol. |
andamian
reviewed
May 25, 2023
| password : str | ||
| The user's password | ||
| """ | ||
| data = { |
There was a problem hiding this comment.
It could probably return here if self._auth_host is set.
There was a problem hiding this comment.
That might be true. If the self._auth_host is set, that just means that self.get_valid_host() was called at some point, not that the current user is logged in.
andamian
approved these changes
May 25, 2023
|
@bsipocz - FYI: this is ready from our perspective. |
keflavich
approved these changes
Jun 1, 2023
Added auth handling to login to Keycloak.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added auth handling to login to Keycloak.
Fixes #2670